Skip to content
This repository was archived by the owner on Apr 2, 2018. It is now read-only.

fix(core): change 'OpaqueToken' to 'InjectionToken' - #64

Open
salkhwlani wants to merge 1 commit into
ionic-team:masterfrom
salkhwlani:master
Open

salkhwlani wants to merge 1 commit into
ionic-team:masterfrom
salkhwlani:master

Conversation

@salkhwlani

@salkhwlani salkhwlani commented Nov 10, 2017 •

Copy link
Copy Markdown

BREAKING CHANGE: OpaqueToken has been removed as it was deprecated since v4. Use InjectionToken instead.

fixed #63 #13385

BREAKING CHANGE: OpaqueToken has been removed as it was deprecated since v4. Use InjectionToken instead.
@youssmak

Copy link
Copy Markdown

@dwieeb could you please merge this pull requests ?

@dtaalbers

Copy link
Copy Markdown

When is this being merged? I'd like to use this fix :)

@minusf

minusf commented Dec 1, 2017

Copy link
Copy Markdown

does it works like a drop in replacement? InjectionToken needs type...

class OpaqueToken {
  constructor(_desc: string)
  protected _desc: string
  toString(): string
}

class InjectionToken<T> {
  constructor(_desc: string)
  protected _desc: string
  toString(): string
}

@wilgert

wilgert commented Mar 2, 2018

Copy link
Copy Markdown

Please merge this PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpaqueToken deprecated in Angular 5

7 participants